Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OpenAi gem 7.0.1 #343

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

Rmpanga
Copy link
Contributor

@Rmpanga Rmpanga commented May 9, 2024

Description

Updated OpenAI Gem to 7.0.1

Testing Done

  1. Ran both system tests and regular tests
  2. Deployed changes locally and confirmed backwards compatibility
  3. Confirmed new Gem was deployed in Rails

Copy link
Contributor

@krschacht krschacht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @Rmpanga ! I just left one comment about the README. If you can take a look at that then we can get this merged in.

I know the ruby-anthropic gem is about to update soon too so maybe you can help me with that as soon as the one pending PR gets merged in. I had to re-open one of the classes from that gem to add some missing methods but I think my hack will be unnecessary once that gem updates:
https://github.com/allyourbot/hostedgpt/blob/main/config/initializers/extend_anthropic_client.rb

README.md Outdated

1. Create a local db by running `bin/rails db:create`
2. Then run the rails migrations by running `bin/rails db:migrate`
3. Finally run `bin/rails test` or `bin/rails test:system`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the setup instructions up on line ~115 of this file. Did you miss that or did those not work for you?

The troubleshooting is a really good thing to add. Assuming my instructions above work, then let's just move this troubleshooting section up around line 119.

@krschacht
Copy link
Contributor

@Rmpanga I just realized that I need the newest version of this gem for a feature I'm working on right now (text to speech using OpenAI)! Even though I left you a comment about the README, I'm anxious to get this merged into main so I can pull it into my branch so I've just done a revision of the README instructions. Take a look at that and let me know if you have any further comments on it. We can continue to improve them in a followup PR.

@krschacht krschacht merged commit e4e19f4 into AllYourBot:main May 9, 2024
6 checks passed
@krschacht
Copy link
Contributor

Oh, and while I have your attention :) I'd love to hear what motivated you to check out HostedGPT? And if you have any feedback on things that are important to you (e.g. missing functionality) let me know and I can take that into consideration. Also, if you've had any trouble with it, that's helpful for me to hear as well.

@Rmpanga
Copy link
Contributor Author

Rmpanga commented May 10, 2024

Thanks for updating @krschacht. I'm proficient (not an expert) with rails and wanted to see if there were any open source Rails ChatGPT projects. I really liked how the project was structured especially having tests & fixtures. I wanted to experiment with different ideas and this project has been very helpful.

Happy to help with the ruby-anthropic gem as well.

@Rmpanga
Copy link
Contributor Author

Rmpanga commented May 10, 2024

One question I did have was the model structure.

I see the attendant was for Conversations to mirror OpenAI threads.
However I noticed that Assistants do not mirror OpenAI assistants

Was the original intent of Assistants to mirror OpenAI assistants?

@krschacht
Copy link
Contributor

Great to hear! One of my hopes for this project is that it’s a good starting point for other projects. Let me move this conversation over to here: #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants